Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
marinofranz
force-pushed
the
feature/universes
branch
2 times, most recently
from
6451222 to
8645771
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Roblox Universes API by introducing a new Universes resource class with methods for universe management and user restriction operations. It also adds a utility for generating idempotency keys and comprehensive type definitions.
- New
UniversesAPI resource with CRUD operations for universe information and user restrictions - Idempotency key generation utility for safely retrying API requests
- Type definitions for universe-related entities including social links, user restrictions, and age ratings
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/resources/universes.ts | Implements the Universes API resource with methods for getting/updating universes and managing user restrictions |
| src/utils/idempotency.ts | Adds utility function to generate unique idempotency keys using timestamp and random values |
| src/types/universes.ts | Defines TypeScript interfaces and types for universe entities and related resources |
| test/idempotency.test.ts | Comprehensive test coverage for the idempotency key generation utility |
| src/index.ts | Registers the new Universes resource with the OpenCloud SDK client |
Comments suppressed due to low confidence (1)
src/index.ts:73
- The Universes class should be exported along with Users and Groups for consistency. Add 'export { Universes } from "./resources/universes";' after line 73.
export { Groups } from "./resources/groups";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
looking to use this resource in my bot, when would this get merged and released? |
- getUserRestriction - updateUserRestriction - updateUserRestriction - listUserRestrictionLogs - types moved to src/types/universes.ts Co-authored-by: Commonly <51011212+commonly-ts@users.noreply.github.com>
marinofranz
force-pushed
the
feature/universes
branch
from
8645771 to
6b4a05f
Compare
We can merge a base version of this today and add |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Implements the Universe resource on the Open Cloud API.
Closes #3
Type of Change
Testing
pnpm test)Code Quality
pnpm lintand fixed any issuespnpm formatto format my codepnpm typecheckand there are no type errorsDocumentation
Breaking Changes
Screenshots/Recordings
Additional Context
Checklist
mainbranch